Skip to content

Port new docs for System.CodeDom, System.Globalization and System.Runtime.CompilerServices, System.Net (EII) and System.Data.SqlTypes (EII)#9131

Merged
carlossanlop merged 6 commits into
dotnet:mainfrom
carlossanlop:SomePorts80
Jul 19, 2023
Merged

Port new docs for System.CodeDom, System.Globalization and System.Runtime.CompilerServices, System.Net (EII) and System.Data.SqlTypes (EII)#9131
carlossanlop merged 6 commits into
dotnet:mainfrom
carlossanlop:SomePorts80

Conversation

@carlossanlop

Copy link
Copy Markdown
Contributor

Ports some missing docs from dotnet/runtime#88561

@carlossanlop carlossanlop requested review from a team and gewarren July 10, 2023 04:21
@carlossanlop carlossanlop requested a review from a team as a code owner July 10, 2023 04:21
@carlossanlop carlossanlop self-assigned this Jul 10, 2023
@carlossanlop carlossanlop changed the title Port new docs for System.CodeDom, System.Globalization and System.Runtime.CompilerServices Port new docs for System.CodeDom, System.Globalization and System.Runtime.CompilerServices, System.Net (EII) and System.Data.SqlTypes (EII) Jul 10, 2023
@learn-build-service-prod

Copy link
Copy Markdown

Learn Build status updates of commit 8c6cf03:

✅ Validation status: passed

File Status Preview URL Details
xml/System.CodeDom.Compiler/IndentedTextWriter.xml ✅Succeeded View
xml/System.Globalization/NumberStyles.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/InlineArrayAttribute.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/RefSafetyRulesAttribute.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/Unsafe.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod

Copy link
Copy Markdown

Learn Build status updates of commit a51298b:

✅ Validation status: passed

File Status Preview URL Details
xml/System.CodeDom.Compiler/IndentedTextWriter.xml ✅Succeeded View
xml/System.Data.SqlTypes/SqlGuid.xml ✅Succeeded View
xml/System.Globalization/NumberStyles.xml ✅Succeeded View
xml/System.Net/IPAddress.xml ✅Succeeded View
xml/System.Net/IPNetwork.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/InlineArrayAttribute.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/RefSafetyRulesAttribute.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/Unsafe.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@wfurt wfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

networking looks good to me. I wish we named parameters better than s Burt it seems like this is what we API approved.

@tarekgh

tarekgh commented Jul 10, 2023

Copy link
Copy Markdown
Member

Globalization looks good. it is really about the new numeric style AllowBinarySpecifier. CC @tannergooding if want to have a look.

@buyaa-n buyaa-n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread xml/System.Runtime.CompilerServices/InlineArrayAttribute.xml Outdated
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@learn-build-service-prod

Copy link
Copy Markdown

Learn Build status updates of commit 3c54085:

✅ Validation status: passed

File Status Preview URL Details
xml/System.CodeDom.Compiler/IndentedTextWriter.xml ✅Succeeded View
xml/System.Data.SqlTypes/SqlGuid.xml ✅Succeeded View
xml/System.Globalization/NumberStyles.xml ✅Succeeded View
xml/System.Net/IPAddress.xml ✅Succeeded View
xml/System.Net/IPNetwork.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/InlineArrayAttribute.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/RefSafetyRulesAttribute.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/Unsafe.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop carlossanlop merged commit 19980b8 into dotnet:main Jul 19, 2023
@carlossanlop carlossanlop deleted the SomePorts80 branch July 19, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants