Disallow edits on fileversioninfo and customreflectioncontext#12505
Merged
gewarren merged 2 commits intodotnet:mainfrom Apr 10, 2026
Merged
Disallow edits on fileversioninfo and customreflectioncontext#12505gewarren merged 2 commits intodotnet:mainfrom
gewarren merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates repo configuration to prevent public contributions to documentation that is generated from source-of-truth repos, specifically targeting System.Diagnostics.FileVersionInfo and System.Reflection.Context.CustomReflectionContext as a follow-up to upstream runtime changes.
Changes:
- Update
docfx.jsonopen_to_public_contributorssettings to mark additional generated reference YAML as not open to public contributors. - Update the GitHub policy
.github/policies/disallow-edits.ymlto close PRs that edit the corresponding generated XML inputs, includingFileVersionInfo.xmlandSystem.Reflection.Context/*. - Broaden the
System.Compositiondisallow pattern to cover sub-namespaces.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docfx.json | Adjusts open_to_public_contributors globs to restrict generated API YAML (but introduces glob issues with flattened output). |
| .github/policies/disallow-edits.yml | Updates PR-closing policy patterns to disallow edits for FileVersionInfo and System.Reflection.Context XML. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to dotnet/runtime#124365 and dotnet/runtime#124405.