This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Allow preinitializing delegates and reading initonly statics#8204
Merged
MichalStrehovsky merged 3 commits intoJun 23, 2020
Conversation
This extends the static constructor interpreter with support for preinitializing delegates and support for reading readonly static fields declared by other types. The readonly static fields can be accessed after interpreting the static constructor of the containing type. This opens us up to recursive dependencies. The interpreter will bail if recursive dependency is hit (we already have a test). This significantly improves the interpreter's ability to run static constructors at compile time: | | Eligible types | Preinitialized before | Preinitialized after | | -------- | -------------- | --------------------- | -------------------- | | WinForms | 1520 | 702 | 967 | | WebApi | 2005 | 746 | 1278 | About 60% of types now have their static constructor executed at compile time.
jkotas
approved these changes
Jun 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the static constructor interpreter with support for preinitializing delegates and support for reading readonly static fields declared by other types.
The readonly static fields can be accessed after interpreting the static constructor of the containing type. This opens us up to recursive dependencies - the interpreter will bail if recursive dependency is hit (we already have a test).
This significantly improves the interpreter's ability to run static constructors at compile time:
About 60% of types now have their static constructor executed at compile time.