Skip to content

Fix E2ETest.ServerExecutionTests.CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit#57604

Closed
MackinnonBuck wants to merge 2 commits intomainfrom
mbuck/fix-circuit-termination-tests
Closed

Fix E2ETest.ServerExecutionTests.CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit#57604
MackinnonBuck wants to merge 2 commits intomainfrom
mbuck/fix-circuit-termination-tests

Conversation

@MackinnonBuck
Copy link
Copy Markdown
Member

Blazor's error UI was overlaying the button that the test was trying to click. This PR fixes the issue by scrolling the button into view before attempting to click it.

Marks #57551 as test-fixed.

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner August 29, 2024 21:32
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 29, 2024
@MackinnonBuck
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Do we know why it only recently started failing? And what other branches this might affect?

I think we'll want to backport this and/or #57606 to at least release/9.0. I saw this cause failures in #57560.

@SteveSandersonMS SteveSandersonMS self-requested a review August 30, 2024 10:02
Copy link
Copy Markdown
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! If this is a reliable fix, you could probably unquarantine the tests at the same time (since they were not actually flaky but 100% failing all the time).

@MackinnonBuck
Copy link
Copy Markdown
Member Author

Do we know why it only recently started failing? And what other branches this might affect?

I'm not totally sure, but it seems related to the testing environment. The way I was able to repro this was shrinking the browser window vertically. I tried various Chrome versions to see if it that was the cause, but it didn't make a difference.

@MackinnonBuck
Copy link
Copy Markdown
Member Author

Hm, let's wait before merging. Despite this fixing the problem for me locally, it didn't seem to fix the problem in CI...

@MackinnonBuck MackinnonBuck added the * NO MERGE * Do not merge this PR as long as this label is present. label Aug 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 10, 2024
@danmoseley danmoseley requested a review from Copilot February 14, 2025 04:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@danmoseley
Copy link
Copy Markdown
Member

@MackinnonBuck merge or close?

@MackinnonBuck
Copy link
Copy Markdown
Member Author

Let's close for now. I'll open a new PR when I revisit the test failure.

@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components * NO MERGE * Do not merge this PR as long as this label is present. pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants