Fix Linux installer dependency versioning#25594
Conversation
|
Hello @JunTaoLuo! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
|
||
| <PackageContentRoot>$(SharedFrameworkLayoutRoot)</PackageContentRoot> | ||
|
|
||
| <MicrosoftNETCoreAppRuntimeMajorMinorVersion>$(MicrosoftNETCoreAppRuntimeVersion.Split('.')[0]).$(MicrosoftNETCoreAppRuntimeVersion.Split('.')[1])</MicrosoftNETCoreAppRuntimeMajorMinorVersion> |
There was a problem hiding this comment.
Why $(DotnetRuntimeDependencyMajorMinorVersion) for Debian and $(MicrosoftNETCoreAppRuntimeMajorMinorVersion) for Red Hat ❔ This seems more sensible
There was a problem hiding this comment.
No particular reason, I guess I was just copying the convention of the nearby files. In the Rpm.TargetingPack.rpmproj it used the name MicrosoftNETCoreAppRefMajorMinorVersion. I took that and changed Ref=>Runtime and used it here. In the debproj I copied the property DotnetTargetingPackDependencyVersion from the line above and added MajorMinor. Ah well.
Fixes ingestion issue in dotnet/installer#8235
The error there was:
This is because we assume that the major.minor between aspnetcore and dotnet-targeting-pack or dotnet-runtime-pack are always aligned. This is not the case in the master branch at the moment since our branding update PR is still in progress. Nevertheless, we should never make that assumption and calculate the major.minor version of the runtime dependencies instead.