Skip to content

Fix Linux installer dependency versioning#25594

Merged
1 commit merged into
masterfrom
johluo/fix-linux-installer-deps
Sep 4, 2020
Merged

Fix Linux installer dependency versioning#25594
1 commit merged into
masterfrom
johluo/fix-linux-installer-deps

Conversation

@JunTaoLuo

Copy link
Copy Markdown
Contributor

Fixes ingestion issue in dotnet/installer#8235

The error there was:

  dpkg: dependency problems prevent configuration of aspnetcore-targeting-pack-5.0:
   aspnetcore-targeting-pack-5.0 depends on dotnet-targeting-pack-5.0 (>= 6.0.0~alpha.1.20428.2); however:
    Package dotnet-targeting-pack-5.0 is not installed.

This is because we assume that the major.minor between aspnetcore and dotnet-targeting-pack or dotnet-runtime-pack are always aligned. This is not the case in the master branch at the moment since our branding update PR is still in progress. Nevertheless, we should never make that assumption and calculate the major.minor version of the runtime dependencies instead.

@JunTaoLuo JunTaoLuo requested review from dougbu and sfoslund September 3, 2020 22:25
@ghost ghost added the feature-installers Includes: Installers label Sep 3, 2020
@ghost

ghost commented Sep 3, 2020

Copy link
Copy Markdown

Hello @JunTaoLuo!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@sfoslund sfoslund left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks John!

@ghost ghost merged commit 54f732e into master Sep 4, 2020
@ghost ghost deleted the johluo/fix-linux-installer-deps branch September 4, 2020 15:49

<PackageContentRoot>$(SharedFrameworkLayoutRoot)</PackageContentRoot>

<MicrosoftNETCoreAppRuntimeMajorMinorVersion>$(MicrosoftNETCoreAppRuntimeVersion.Split('.')[0]).$(MicrosoftNETCoreAppRuntimeVersion.Split('.')[1])</MicrosoftNETCoreAppRuntimeMajorMinorVersion>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why $(DotnetRuntimeDependencyMajorMinorVersion) for Debian and $(MicrosoftNETCoreAppRuntimeMajorMinorVersion) for Red Hat ❔ This seems more sensible

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason, I guess I was just copying the convention of the nearby files. In the Rpm.TargetingPack.rpmproj it used the name MicrosoftNETCoreAppRefMajorMinorVersion. I took that and changed Ref=>Runtime and used it here. In the debproj I copied the property DotnetTargetingPackDependencyVersion from the line above and added MajorMinor. Ah well.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-installers Includes: Installers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants