Remove Special Casing of RemoteExecutor Detection for Single File#12348
Merged
MichalStrehovsky merged 1 commit intodotnet:mainfrom Mar 16, 2023
ivdiazsa:no-remote-executor
Merged
Remove Special Casing of RemoteExecutor Detection for Single File#12348MichalStrehovsky merged 1 commit intodotnet:mainfrom ivdiazsa:no-remote-executor
MichalStrehovsky merged 1 commit intodotnet:mainfrom
ivdiazsa:no-remote-executor
Conversation
MichalStrehovsky
approved these changes
Jan 30, 2023
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Thank you!
I've put a no merge label. This must not merge before your runtime repo change. There's no urgency in merging this - we should just not forget to do this at some point.
Contributor
Author
|
It's been a bit. Should we merge this now @MichalStrehovsky? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the special case of
RemoteExecutordetection inIsSupported(). The reason for this is that in dotnet/runtime's PR #80946 (dotnet/runtime#80946), we are setting theDOTNET_REMOTEEXECUTOR_SUPPORTEDEnvironment Variable to 0, and sinceIsSupported()here looks for the aforementioned variable to be different from 0, then the RemoteExecutor detection became redundant.This PR is expected to be merged after the one in dotnet/runtime.