Fix: add binding projects to the solution so examples resolve in IDEs#54
Merged
Conversation
The examples ProjectReference Glyph11.Native / Glyph11.Pico, but those projects weren't in src/Glyph11.sln — so IDEs couldn't resolve them (CLI builds were fine). Add both to the solution. To keep release.yml from shipping them (the solution pack would have packed the bindings without their native binaries), point the managed Release job at Glyph11/Glyph11.csproj specifically — the bindings publish via package-native.yml / package-pico.yml. Also gitignore the local benchmarking feed. Verified: solution builds; packing Glyph11.csproj produces only Glyph11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Glyph11.Pico(andGlyph11.Native) couldn't be resolved when theGlyph11.Pico.Example/Glyph11.Native.Exampleprojects were open — the examplesProjectReferencethe binding projects, but those weren't members ofsrc/Glyph11.sln, so IDEs flagged the references as unresolved (CLI builds worked because MSBuild follows the path regardless).Fix:
Glyph11.NativeandGlyph11.Picotosrc/Glyph11.sln, so everything the examples reference is in the solution.srcsolution) wouldn't ship them without their native binaries. To keep that safe, the Release job now packsGlyph11/Glyph11.csprojspecifically — the bindings publish viapackage-native.yml/package-pico.ymlwith their natives bundled.Verified: the full solution builds (0 errors, examples resolve), and
dotnet pack Glyph11/Glyph11.csprojproduces onlyGlyph11.0.3.5.nupkg.