Conversation
arhimede
approved these changes
Feb 17, 2023
marioradu05
reviewed
Feb 17, 2023
| */ | ||
| class UserController extends AbstractActionController | ||
| { | ||
| protected CookieService $cookieService; |
Member
There was a problem hiding this comment.
Can we use the CookieServiceInterface here? And everywhere else where it's possible.
| * @throws MissingConfigurationException | ||
| */ | ||
| public function slugManipulation(Slug $slug, string $attribute, string $value) | ||
| public function slugManipulation(Slug $slug, string $attribute, string $value): bool|string |
Member
There was a problem hiding this comment.
Should we change this method to return only string and null?
| if (! isset($this->config['orm_default']['identity_property'])) { | ||
| throw new Exception("No or invalid param 'identity_class' provided."); | ||
| if (!isset($this->config['identity_property'])) { | ||
| throw new Exception("Missing or invalid param 'identity_class' provided."); |
Member
There was a problem hiding this comment.
This was my mistake back it the day, the error message should be "Missing or invalid param 'identity_property' provided." because we are checking for the "identity_property" not "identity_class".
| 'uuid' => $this->getUuid()->toString(), | ||
| 'detail' => ($this->getDetail() instanceof UserDetail) ? $this->getDetail()->getArrayCopy() : null, | ||
| 'avatar' => ($this->getAvatar() instanceof UserAvatar) ? $this->getAvatar()->getArrayCopy() : null, | ||
| 'detail' => $this->getDetail()?->getArrayCopy(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
laminas-servicemanager requires ocramius/proxy-manager
ocramius/proxy-managercannot be installed because it requires PHP ~8.0.0 BUT DK Frontend requires PHP ~8.1.0 || ~8.2.0friendsofphp/proxy-manager-lts is a fork of
ocramius/proxy-managerthat replacesocramius/proxy-managerI added
friendsofphp/proxy-manager-ltsas a requirement in composer.json