Skip to content

shows diff in terminal#8377

Closed
agzam wants to merge 1 commit into
doomemacs:masterfrom
agzam:feat__on-upgrade-show-diff-in-terminal
Closed

shows diff in terminal#8377
agzam wants to merge 1 commit into
doomemacs:masterfrom
agzam:feat__on-upgrade-show-diff-in-terminal

Conversation

@agzam

@agzam agzam commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

if gh is installed, shows the diff in the terminal (instead of browser)

Replace this with a summary of what you've changed and why, followed by a list of issues it affects, if any.

Fix: #0000
Ref: #0000
Close: #0000


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to Doom's git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

@agzam
agzam force-pushed the feat__on-upgrade-show-diff-in-terminal branch from cc804bb to 0df4b64 Compare April 30, 2025 21:47
@agzam
agzam force-pushed the feat__on-upgrade-show-diff-in-terminal branch from 0df4b64 to 117cc57 Compare April 30, 2025 21:47
@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones core:cli Pertains to the `$ doom` script or CLI libraries was:moved Is, was, or will be addressed elsewhere labels Aug 10, 2025
@hlissner hlissner added this to the core v3.0 milestone Aug 10, 2025
@hlissner

Copy link
Copy Markdown
Member

The direction I want to take with doom upgrade is to display (or link to) portions of an org changelog (which won't exist until v3), rather than display raw git diffs, so I must turn this down. Thanks for the PR and for bringing it to my attention, in any case!

@hlissner hlissner closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core:cli Pertains to the `$ doom` script or CLI libraries is:feature Adds or requests new features, or extends existing ones was:moved Is, was, or will be addressed elsewhere

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants