signXmlFile.ini is referenced in 3 locations but the code uses xmlSigner.ini#3
Open
scottgshin wants to merge 2 commits into
Open
signXmlFile.ini is referenced in 3 locations but the code uses xmlSigner.ini#3scottgshin wants to merge 2 commits into
scottgshin wants to merge 2 commits into
Conversation
…de. 'xmlSigner.ini' is used in the code and matches the project and internal filenames so switch all references and filenames to 'xmlSigner.ini'.
…de. 'xmlSigner.ini' is used in the code and matches the project and internal filenames so switch all references and filenames to 'xmlSigner.ini'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the reference to signXmlFile.ini to xmlSigner.ini to match the code and added a comment on how to find the thumbprint of the code signing certificate.
Thank you for the auto update feature, wingup, for Notepad+. I have incorporated the functionality into my project and am now adding the new security features.