Fix on isExternal function (issue #1477)#1509
Fix on isExternal function (issue #1477)#1509GiuliCler wants to merge 1 commit intodocsifyjs:developfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/brcirctsb |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e93a26a:
|
|
Hi @GiuliCler -- I'm closing this PR in favor of #1510. The reason is that this PR doesn't actually "fix" the Thank you for taking the time to file the PR though. Very much appreciated! |
Summary
This pull request should fix issue #1477 about security bug, still present in the last release.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.