feat: add support for AWS European Sovereign Cloud ECR #914
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphi
force-pushed
the
add-support-for-amazonaws.eu
branch
2 times, most recently
from
5d5bcf3 to
5b4afe1
Compare
crazy-max
requested changes
Jan 13, 2026
package.json
Outdated
Comment on lines
29
to
30
| "@aws-sdk/client-ecr": "^3.966.0", | ||
| "@aws-sdk/client-ecr-public": "^3.966.0", |
Member
There was a problem hiding this comment.
Let's keep the update in a dedicated PR through dependabot: #909
Member
|
Check lint issue and run pre-checkin: https://github.com/docker/login-action/blob/master/.github/CONTRIBUTING.md#submitting-a-pull-request |
dphi
force-pushed
the
add-support-for-amazonaws.eu
branch
from
5b4afe1 to
cc7857c
Compare
- Update ECR registry regex to match `.amazonaws.eu` domain suffix - Add test cases for `eusc-de-east-1.amazonaws.eu` region format Fixes: docker#908 Signed-off-by: Philipp Dreimann <[email protected]> Tested-by: Lukas Valentin Buchmeier-Probst <[email protected]>
dphi
force-pushed
the
add-support-for-amazonaws.eu
branch
from
cc7857c to
f6ef577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #908