-
Notifications
You must be signed in to change notification settings - Fork 374
chore: bump go dependencies (acp-go-sdk, goja) #2995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12
−9
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MEDIUM] Logout returns
acp.NewMethodNotFound— verify this is the correct error for an optional-but-present methodThe new
Logoutstub returnsacp.NewMethodNotFound(acp.AgentMethodLogout)to signal the method is not supported. The adjacentLoadSessionstub (on the separate, optionalacp.AgentLoaderinterface) useserrors.New("load session not supported")instead.The concern is about protocol semantics: if the ACP framework treats
MethodNotFoundas a hard protocol error (e.g., causing the client to drop the connection or enter an error state), any client that sends a Logout request will experience a disruption rather than graceful degradation.Logoutis part of the coreacp.Agentinterface (not an optional sub-interface), soNewMethodNotFoundmay be the idiomatic way to say "this method exists in the interface but is not implemented here." However, it's worth confirming against the SDK changelog or the ACP protocol spec that this error code is handled gracefully by clients. If there's any doubt, using a plainerrors.New("logout not supported")(matching theLoadSessionpattern) would be the safer choice until the protocol semantics are confirmed.