-
Notifications
You must be signed in to change notification settings - Fork 230
Add Linux installation script #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jean-Laurent de Morlhon <[email protected]>
6b8c22a to
308dde9
Compare
| # Make executable | ||
| chmod +x "$tmp_file" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do this with install later.
| # Make executable | |
| chmod +x "$tmp_file" |
| sudo mv "$tmp_file" "$target_path" | ||
| sudo chmod +x "$target_path" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| sudo mv "$tmp_file" "$target_path" | |
| sudo chmod +x "$target_path" | |
| sudo install -m 755 "$tmp_file" "$target_path" |
| sudo mv "$tmp_file" "$target_path" | ||
| sudo chmod +x "$target_path" | ||
| else | ||
| mv "$tmp_file" "$target_path" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| mv "$tmp_file" "$target_path" | |
| install -m 755 "$tmp_file" "$target_path" |
krissetto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably check for the existence of curl as well, as folks end ip using convenience scripts like this in ci like environments where curl presence is not always a given
|
|
||
| # Try using gh CLI first if available | ||
| if command -v gh &> /dev/null; then | ||
| gh release list --repo "$REPO" --limit 1 --json tagName --jq '.[0].tagName' 2>/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we need both options here, i'd just go straight to the rest api unless there are other reasons for using gh
| print_msg "$YELLOW" " 2. Use Homebrew: brew install cagent" | ||
| exit 1 | ||
| ;; | ||
| MINGW*|MSYS*|CYGWIN*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: harmless, i don't think many windows users will try to run a bash script called install-linux
Adds a one-line installer for Linux users similar to Homebrew and Claude Code's installation experience.
Before: Linux users had to manually download binaries, chmod, rename, and configure PATH.
After: Single command installation with automatic setup and verification.