Skip to content

Fixed compiling with minSDK in manifest file error#1

Merged
dkfl1995 merged 1 commit intomasterfrom
dkfl1995-minSDK-patch
Aug 31, 2018
Merged

Fixed compiling with minSDK in manifest file error#1
dkfl1995 merged 1 commit intomasterfrom
dkfl1995-minSDK-patch

Conversation

@dkfl1995
Copy link
Owner

Does any other open PR do the same thing?

Any

What issue is this PR fixing?

No one. It was my own first.

How did you test this PR?

Android only!
When upgrading to newer gradle wrapper package versions that works with buildtools version 28+, error comes up if uses-sdk tag has "minSDK" property defined inside AndroidMainfest.xml file. Default SDK properties should stand only inside build.gradle files.

My steps to reproduce:
try to compile react-native in Android Studio with:

  1. gradle-wrapper package version in gradle-wrapper.properties:
    distributionUrl=https\://services.gradle.org/distributions/gradle-4.9-all.zip
  2. App`s build.gradle file buildToolsVersion 28.0.2.
  3. Gradle plugin version I used (the newest at that time):

dependencies { classpath 'com.android.tools.build:gradle:3.3.0-alpha08' }

You will receive an gradle sync error:

Error:The minSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file.

When upgrading to newer gradle wrapper package versions that works with buildtools version 28+, error comes up if uses-sdk tag has "minSDK" property defined inside AndroidMainfest.xml file. Default SDK properties should stand only inside build.gradle files.
@dkfl1995 dkfl1995 merged commit dddee78 into master Aug 31, 2018
@dkfl1995 dkfl1995 deleted the dkfl1995-minSDK-patch branch August 31, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant