Support for Laravel 4.2#44
Conversation
I just started playing with Laravel 4.2 and got a lot of issues installing this package. I have suggested the following allowing for 4.1.* and 4.2.* installations. I believe this would work if not let me know of way.
|
Better to use |
|
@GrahamCampbell is that ok? what is the difference? |
|
The difference is that you where saying get any version so long as it is at least 4.1. That means we could be getting verion 6.3 for example. Using ~ means we are getting any 4.x version so long as it is at least 4.1. |
|
Have you checked that the package actually works under 4.2? I haven't looked yet. Hoping nothing has changed in the router. |
|
It seems to have passed tests ok. |
|
@bweston92 That's because the test suite loaded laravel 4.1, not 4.2... |
|
Hmm want me to pull and do the tests on 4.2?— On Wed, May 14, 2014 at 10:43 AM, Graham Campbell
|
|
Has anyone been able to confirm this is good? I'd really love it if this could be merged so I can update Laravel to 4.2 beta. |
|
I'll be taking a look in the coming days. :-)
|
|
Fantastic! I'm chomping at the bit to use the new global scopes in 4.2 :) Excellent package BTW. Love it. |
|
👍 For this, I'm using this fork on my project for now but it's such a lightweight pull I hope it gets merged soon. |
|
I'm doing the same. Seems to work okay. On Fri, May 23, 2014 at 12:19 AM, Maxime Fabre notifications@github.com
|
|
Going to merge this in and hopefully anything that's going to pop up will show itself before this package stabilizes. |
5 participants
I just started playing with Laravel 4.2 and got a lot of issues installing this package. I have suggested the following allowing for 4.1.* and 4.2.* installations.
I believe this would work if not let me know of way.