Fix #542: Correct Codex model configuration from gpt-5.2-codex to gpt-5.2#543
Fix #542: Correct Codex model configuration from gpt-5.2-codex to gpt-5.2#543ding113 wants to merge 1 commit into
Conversation
Changed the model name in usage-doc configuration examples from "gpt-5.2-codex" to "gpt-5.2" as the "-codex" suffix causes API errors. The API only supports "gpt-5.2" as the model name. Fixes #542 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Summary of ChangesHello @ding113, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical documentation error that was causing configuration failures for users of the Codex model. By updating the model name in the usage guide, it ensures that users can correctly set up their configurations without encountering HTTP 400 errors, thereby improving the overall user experience and reliability of the documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthrough此PR修正了用户文档中的模型配置示例,将两处Codex配置块中的模型引用从"gpt-5.2-codex"更新为"gpt-5.2",以符合API实际支持的模型标识。 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where an incorrect model name was used in the usage documentation. The change correctly replaces gpt-5.2-codex with gpt-5.2 in the configuration examples for the Codex CLI within src/app/[locale]/usage-doc/page.tsx. This correction aligns with the problem description and improves the accuracy of the documentation. The changes are focused and I see no further issues. This looks good to merge.
🧪 测试结果
总体结果: ✅ 所有测试通过 |
There was a problem hiding this comment.
Code Review Summary
No significant issues identified in this PR.
PR Size: XS
- Lines changed: 4
- Files changed: 1
Review Coverage
- Logic and correctness - Clean
- Security (OWASP Top 10) - Clean
- Error handling - Clean
- Type safety - Clean
- Documentation accuracy - Clean
- Test coverage - Adequate
- Code clarity - Good
Automated review by Codex AI
There was a problem hiding this comment.
- Reviewed PR
#543(1 file; 2 additions / 2 deletions → 4 lines changed) and applied thesize/XSlabel. - Diff scope:
src/app/[locale]/usage-doc/page.tsx:642andsrc/app/[locale]/usage-doc/page.tsx:688(doc example model changed togpt-5.2). - Submitted a PR review summary via
gh pr reviewwith no issues found (no inline comments posted).
Summary
Fixed incorrect Codex model name in usage documentation from
gpt-5.2-codextogpt-5.2.Problem
Fixes #542
The usage documentation showed an incorrect model configuration for Codex:
This causes a 400 error:
Related Issues:
Note: Issue #542 comment mentioned that CHANGELOG.md (line 359) already documents the correct model name as
gpt-5.2, confirming this documentation fix aligns with the intended configuration.Solution
Changed the model name to the correct value:
Changes
Core Changes
src/app/[locale]/usage-doc/page.tsxto usegpt-5.2instead ofgpt-5.2-codexin both the auth.json and env-var configuration examples (2 occurrences)Testing
gpt-5.2-codexhave been removed from usage documentationChecklist
Description enhanced by Claude AI