Skip to content

Added public reposition method and escCloseAll option#8

Closed
MGotink wants to merge 3 commits into
dinbror:masterfrom
MGotink:master
Closed

Added public reposition method and escCloseAll option#8
MGotink wants to merge 3 commits into
dinbror:masterfrom
MGotink:master

Conversation

@MGotink

@MGotink MGotink commented May 2, 2013

Copy link
Copy Markdown

I've added a public reposition method to allow manual repositioning of the popup after the contents have been changed.
I've also added the escCloseAll option to control if all open or only the topmost popup should be closed, default true.

Regards,
Martin

@byo

byo commented Sep 19, 2013

Copy link
Copy Markdown

I really like the reposition option 👍

@mscalora

Copy link
Copy Markdown

I like the reposition option too

@dinbror

dinbror commented Jul 22, 2014

Copy link
Copy Markdown
Owner

@dinbror dinbror closed this Jul 22, 2014
@pavdro

pavdro commented Jul 31, 2014

Copy link
Copy Markdown

Just wanted to give a heads up on the reposition function.
Don't know if anyone tested it, but there's a clear bug in it.
When repositioning IF statement only checks for fixedPosStyle and not fixedVPos and fixedHPos, so in my case "position: ['auto', 0]", it doesn't reposition it properly in the center.

Think there are also some hardcoded values in there as well.

Update
Also why is there "if (inside) " check no idea???

@dinbror

dinbror commented Aug 2, 2014

Copy link
Copy Markdown
Owner

Hey pavdro.

You're right. Didn't test against that use case. Will have a fix in the next release.
The "if(inside)" is mostly for when you resize the window. If the popup is too big and doesn't fit the window it won't move the popup to ensure that you always can see everything inside the popup.

@dinbror dinbror reopened this Aug 2, 2014
@pavdro

pavdro commented Aug 2, 2014

Copy link
Copy Markdown

Nice 1!
yeah I got resizing case, but it still kinda screws up stuff. maybe move the check into option so make it optional?

@pavdro

pavdro commented Aug 4, 2014

Copy link
Copy Markdown

Actually.
I know what you mean, I think to fix my issue separating inside to X and Y will fix it. Since I still want it to align to center even if vertically it should stay on the same spot.

@dinbror

dinbror commented Jan 24, 2015

Copy link
Copy Markdown
Owner

fixed in v. 0.11.0

@dinbror dinbror closed this Jan 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants