Merged
Conversation
This is a little tricky because Mapbox filters do not work on arrays. Instead we flatten the array into: arrayField.0: arrayValue0, arrayField.1: arrayValue1, arrayField.2: arrayValue2 Then pass the same filter to each of these and group with an ‘any’ filter.
Merged
mojodna
reviewed
Dec 6, 2016
| p[v] = typeof p[v] === 'undefined' ? 1 : p[v] + 1 | ||
| v = Array.isArray(v) ? v : [v] | ||
| v.forEach(function (w) { | ||
| p[w] = typeof p[w] === 'undefined' ? 1 : p[w] + 1 |
There was a problem hiding this comment.
My eye snagged on this. Is this the same as:
v.forEach(w => {
p[w] = (p[w] || 0) + 1
})
Member
Author
There was a problem hiding this comment.
Yes it would be, although I try to avoid this pattern when I remember to, because you can get bugs when you have falsey values (e.g. p[w] = 0), although in this case we would be fine, I think the more explicit code is better.
|
LGTM on a cursory reading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little tricky because Mapbox filters do not work on arrays. Instead we flatten the array into:
Then pass the same filter to each of these and group with an ‘any’ filter.
Things not working quite right, or untested: