Add bindings to ReflectionProfile methods#79
Conversation
This reverts commit 7253d99.
|
Hi @ezatterin - thanks for the changes and the fix. Could you add a unit test (for good measure) with the new functions ? I think the PR also needs a |
|
yes, thanks @ezatterin and @vincefn . The news will turn into the changelog at the next release. |
* GetProfile now accepts numpy arrays as the `x` argument
|
Finally made it 🚀 I had to add an additional wrapper to use the |
|
Thanks @ezatterin We will review. I added this to the |
|
@vincefn please can you check you are ok to merge this? We are moving things forward to the next release so it would be nice to have this in there. @ezatterin do you think documentation is adequate for folks to know how to use this? Bear in mind that we auto-build API docs from the docstrings, so if these are just library capabilities that may be enough, but if there are interesting things to do with this we could put an example in the docs. |
|
This looks fine for me, even if I have not had the time to test all the details (notably the changes of the setup.py). |
|
@vincefn that is a good point. We should test the build with the new I will wait for @ezatterin to comment and then merge. |
Summary of changes:
allow to build the library via
pip install .outside of a conda env usingsysconfigto find the location of the shared libs.added python bindings for the
ReflectionProfilepublic methods:Tested on Ubuntu 24.04 and Windows 11.