fix: fix load single peak in py3 support#178
Open
stevenhua0320 wants to merge 2 commits intodiffpy:mainfrom
Open
fix: fix load single peak in py3 support#178stevenhua0320 wants to merge 2 commits intodiffpy:mainfrom
stevenhua0320 wants to merge 2 commits intodiffpy:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 3 3
Lines 51 51
=======================================
Hits 39 39
Misses 12 12 🚀 New features to boost your workflow:
|
Contributor
Author
|
@sbillinge I believe we have no tests to cover the issue here (since the tests only contain the easiest one written on 2024 summer by you and me), so it needs some human wisdom to decide if it is correct or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review. Note that there are a lot of
py2legacy in this package. (My bad, I did not clean it up comprehensively on 2024). Now it would give a plot when I run the commandsrmise docs/examples/data/Ag-nyquist-qmax30.gr --plot --range 2 3.5 --baseline "Polynomial(degree=1)"it would give me the plot below.Also there are some messages for the fitting process: