feat: add diffpy.app runmacro <.dp-in file> entry point#7
feat: add diffpy.app runmacro <.dp-in file> entry point#7sbillinge merged 2 commits intodiffpy:mainfrom
diffpy.app runmacro <.dp-in file> entry point#7Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage 92.46% 92.46%
=======================================
Files 4 4
Lines 146 146
=======================================
Hits 135 135
Misses 11 11
🚀 New features to boost your workflow:
|
ycexiao
left a comment
There was a problem hiding this comment.
@sbillinge, it's ready for review.
| ---------- | ||
| equation_string : str, optional | ||
| Equation passed to FitContribution.setEquation. | ||
| equation : list of str, optional |
There was a problem hiding this comment.
All arguments are passed as list.
|
I merged this but I am a bit worried that we are not testing enough. It looked as if we were jut testing that the right variable values were parsed, but not testing anything about fucntionality or resulting code. Is that right? |
|
Yes. There are three layers: (1) the I think we don't need to worry too much about the first two layers, but the third layer needs more tests. |
What problem does this PR address?
Closes #6
Add an entry point and refactor the existing code.
What should the reviewer(s) do?