Conversation
Contributor
Author
|
Reverting part of 3812713, realize why the naming was as such before now |
Member
|
As you say - needs test, but looks great! |
Contributor
Author
|
Actually no new test needed. The default |
Member
|
Updated the changelogs. This LGTM. I'll merge and release late tonight / early tomorrow unless I hear otherwise from somebody. |
Contributor
Author
|
Sounds good!
…On Sun, Oct 6, 2019 at 1:47 PM Ned Twigg ***@***.***> wrote:
Updated the changelogs. This LGTM. I'll merge and release late tonight /
early tomorrow unless I hear otherwise from somebody.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#469?email_source=notifications&email_token=AAKMJPVGF4ZHNVQRAHNOIKTQNIQCXA5CNFSM4I52TD4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAOPYMY#issuecomment-538770483>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKMJPSLEZBPJ4YVKRPGZ4TQNIQCXANCNFSM4I52TD4A>
.
|
Contributor
Author
|
Made just a couple touchups to the comments and trailing paren formatting. Comments weren't quite right before |
Contributor
Author
|
Spotless overwrote my paren formatting |
Member
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #419 by invoking the new
format(Params)API in KtLint 0.34+. This API also lays groundwork for adding editorconfig in the future since the newParamsAPI allows specifying one. Opportunistically also fixed some stale names in 3812713.Starting this now for early review, will add a test next.