chore: doc updates and list-instances#96
Merged
Conversation
tonsV2
requested changes
Apr 30, 2026
| GEN_GRAFANA_HOSTNAME=grafana.127-0-0-1.nip.io \ | ||
| make generate-stack-envs | ||
|
|
||
| make launch-traefik & |
Collaborator
There was a problem hiding this comment.
Some place we use "COMPOSE_OPTS=-d" and others postfix with "&". We should be consistent
Contributor
Author
There was a problem hiding this comment.
Do you think it might make sense to put the -d into the compose commands in the Makefile by default?
Contributor
Author
There was a problem hiding this comment.
Possible solution for Makefile:
# at the top of the Makefile
DETACH ?= true
ifeq ($(DETACH),true)
DETACH_FLAG = -d
endif
Then up $(DETACH_FLAG) $(COMPOSE_OPTS) in each target.
To run attached the user would pass DETACH=false make launch-traefik
Co-authored-by: Philip-Larsen-Donnelly <35666657+Philip-Larsen-Donnelly@users.noreply.github.com>
tonsV2
added a commit
that referenced
this pull request
May 7, 2026
…s on th… (#94) * Reapply "feat: initial support for deploying multiple instances on the same host. WIP" This reverts commit ed9278f. * feat: per-project backup paths * chore: doc updates and list-instances (#96) * chore: doc updates and list-instances * Apply suggestions from code review - remove numbering in reference file Co-authored-by: Philip-Larsen-Donnelly <35666657+Philip-Larsen-Donnelly@users.noreply.github.com> * fix: review comments * fix: add shebang to env-utils.sh to fix shellcheck SC2148 * feat: add delete-instance target to remove instance data and env file * refactor: rename launch-* targets to start-* for consistency with stop-instance * refactor: rename monitoring_net network to monitoring * fix: resolve shellcheck SC1091/SC2119 warnings in generate scripts --------- Co-authored-by: Philip-Larsen-Donnelly <phil@dhis2.org> Co-authored-by: Philip-Larsen-Donnelly <35666657+Philip-Larsen-Donnelly@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.