fix: trust system CA for model downloads + optional .gitignore bypass#39
Merged
Conversation
Model downloads go through ureq, which by default trusts only the bundled webpki-roots and ignores the OS trust store — so they fail behind corporate TLS-inspecting proxies that use a custom CA. Enable ureq's "native-certs" feature so it loads the platform certificate store (macOS Keychain / Linux /etc/ssl), which includes the standard roots plus any enterprise CA. Closes #27.
walk_vault hardcoded standard_filters(true), so .gitignore/.ignore always excluded matching files from indexing with no override. Add a respect_gitignore config option (default true — unchanged behavior) and an `engraph index --no-gitignore` flag. When disabled, the walker still skips hidden entries (.git/, dotfiles) and honors explicit exclude patterns, but stops consulting VCS ignore files. Closes #23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes from open-issue triage.
Closes #27 — trust the system CA store
Model downloads go through
ureq, which by default trusts only bundled webpki-roots and ignores the OS trust store — so they fail behind corporate TLS-inspecting proxies with a custom CA. Enables ureq'snative-certsfeature (macOS Keychain / Linux/etc/ssl), which includes the standard roots plus any enterprise CA.Closes #23 — optional .gitignore bypass
Adds a
respect_gitignoreconfig option (defaulttrue— unchanged behavior) and anengraph index --no-gitignoreflag. When off, the walker still skips hidden entries (.git/, dotfiles) and explicit excludes, but stops honoring.gitignore/.ignore.Verification
cargo fmt --check,cargo clippy -- -D warnings,cargo test --lib(467 passed) all green locally. Includes a RED→GREEN regression test for the toggle.