Skip to content

fixed title (overflow & size)#72

Merged
devvsakib merged 4 commits intodevvsakib:mainfrom
MohamedAlDeep:main
Jan 23, 2023
Merged

fixed title (overflow & size)#72
devvsakib merged 4 commits intodevvsakib:mainfrom
MohamedAlDeep:main

Conversation

@MohamedAlDeep
Copy link
Copy Markdown
Contributor

@MohamedAlDeep MohamedAlDeep commented Jan 22, 2023

Hello,
So i fixed the overflow issue No: #52,
so you see that i added id for the card div (it was to change some css for the div but it didnt work ) so you can delete it if you want.

In css i added

h3{
  max-width:  100%;
  overflow: break-word;
}

which break the words when overflowing and that is it

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
github-error-solve ✅ Ready (Inspect) Visit Preview 💬 1 unresolved Jan 23, 2023 at 11:18AM (UTC)

@MohamedAlDeep
Copy link
Copy Markdown
Contributor Author

image
image

Copy link
Copy Markdown
Owner

@devvsakib devvsakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff.
are you able to change the title size lg to sm? bcz title size is pretty big
line: 48

@MohamedAlDeep
Copy link
Copy Markdown
Contributor Author

Sure

@MohamedAlDeep
Copy link
Copy Markdown
Contributor Author

@devvsakib
Hi i did it but i dont know which size in px
16px
image

14px
image
10px
Uploading image.png…

2 similar comments
@MohamedAlDeep
Copy link
Copy Markdown
Contributor Author

@devvsakib
Hi i did it but i dont know which size in px
16px
image

14px
image
10px
Uploading image.png…

@MohamedAlDeep
Copy link
Copy Markdown
Contributor Author

@devvsakib
Hi i did it but i dont know which size in px
16px
image

14px
image
10px
Uploading image.png…

@MohamedAlDeep
Copy link
Copy Markdown
Contributor Author

Done the size is 15px
I find it not too small and not like the old size

@MohamedAlDeep MohamedAlDeep changed the title fixed title overflow fixed title (overflow & size) Jan 22, 2023
@MohamedAlDeep
Copy link
Copy Markdown
Contributor Author

MohamedAlDeep commented Jan 23, 2023

@devvsakib
hey are you going to merge or is there a problem ?

@devvsakib devvsakib merged commit fb5e7fc into devvsakib:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants