showMore/less#62
Merged
devvsakib merged 1 commit intodevvsakib:mainfrom Jan 19, 2023
safil-badarudeen:readMore/less_button
Merged
showMore/less#62devvsakib merged 1 commit intodevvsakib:mainfrom safil-badarudeen:readMore/less_button
devvsakib merged 1 commit intodevvsakib:mainfrom
safil-badarudeen:readMore/less_button
Conversation
- added button in the style of description itself to show more and less of description which is more than 100 letter
- changed styling line-clamp-3 to line-clamp-11 because old styling was limiting description display functionality eventhough toggling use state works fine
- chose line-clamp-11 because the biggest description in project in 10 line , so just chosed on line more,
- line clamp am talking about is in Errorcard.jsx line number 56
//for future//
- line-clamp should be increased if description not fits in 11 line
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
ps: only real change made in ErrorCard.jsx, |
devvsakib
approved these changes
Jan 19, 2023
Owner
devvsakib
left a comment
devvsakib
left a comment
There was a problem hiding this comment.
really appreciate your hard work. amazing work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.