Skip to content

removed extra clear button#60

Merged
devvsakib merged 1 commit intodevvsakib:mainfrom
hussain-shariff:issue#56
Jan 18, 2023
Merged

removed extra clear button#60
devvsakib merged 1 commit intodevvsakib:mainfrom
hussain-shariff:issue#56

Conversation

@hussain-shariff
Copy link
Copy Markdown
Contributor

Screenshot (179)

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
github-error-solve ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 0:35AM (UTC)

Copy link
Copy Markdown
Owner

@devvsakib devvsakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any button here, did you just remove the button?

image

@hussain-shariff
Copy link
Copy Markdown
Contributor Author

I can't see any button here, did you just remove the button?

image

@devvsakib it will be visible when you hover on the search bar

@devvsakib
Copy link
Copy Markdown
Owner

?? @hussain-shariff
image

@devvsakib
Copy link
Copy Markdown
Owner

please check the preview to confirm that it's working, I can't see any close button when I hover, even if I type something its not visible @hussain-shariff

@hussain-shariff
Copy link
Copy Markdown
Contributor Author

please check the preview to confirm that it's working, I can't see any close button when I hover, even if I type something its not visible @hussain-shariff

Screenshot (180)
@devvsakib Its visible in preview

@devvsakib
Copy link
Copy Markdown
Owner

Okkkyyyy. I checked on the chrome browser, it's working fine, but not working in firefox. can you figure out what happens here?
also when the search input is empty, the scrollbar shows, but when we type something scrollbar disappears.
image
image

maybe if we change the input type search to text, it may help. what do you think?

@hussain-shariff
Copy link
Copy Markdown
Contributor Author

Okkkyyyy. I checked on the chrome browser, it's working fine, but not working in firefox. can you figure out what happens here? also when the search input is empty, the scrollbar shows, but when we type something scrollbar disappears. image image

maybe if we change the input type search to text, it may help. what do you think?

The scrollbar disappears as there is no lot content to scroll.
Screenshot (181)
If you see in this screenshot, for a valid input having 2-3 rows of errors , the scrollbar is still visible.

@hussain-shariff
Copy link
Copy Markdown
Contributor Author

@devvsakib

@devvsakib devvsakib merged commit cea6986 into devvsakib:main Jan 18, 2023
@devvsakib
Copy link
Copy Markdown
Owner

@hussain-shariff amazing work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants