Fix #188 : add highlighte/active status to tag when user filter.#190
Merged
devvsakib merged 1 commit intodevvsakib:mainfrom Jul 16, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, MohitKambli! 🎉 Thank you for submitting your first pull request to GES. Your contribution is valuable and we appreciate your efforts to improve our project. We'll review your changes and provide feedback as soon as possible. Keep up the great work!
devvsakib
approved these changes
Jul 16, 2024
Owner
devvsakib
left a comment
devvsakib
left a comment
There was a problem hiding this comment.
LGTM.
Instead of using a new state for the tag, you could use the type state by passing it to the SearchInput component from home component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Hope you're doing well.
As it has been requested in issue #188, I have added the necessary code for highlighting the selected tag on the main page.
This highlight is red in color that would surround the selected tag.
Hope these code changes meet the requirements.
If at all you find any issues from my end or any incorrect behaviour in the application, then kindly let me know.
Sincere apologies for the same if you find any mistakes.
Thank you for understanding.
Regards,
Mohit Kambli