Skip to content

Added Hamburger menu for smaller devices#184

Merged
devvsakib merged 1 commit intodevvsakib:mainfrom
gandholi-kumar:add_hamburger_menu_for_small_device
Oct 11, 2023
Merged

Added Hamburger menu for smaller devices#184
devvsakib merged 1 commit intodevvsakib:mainfrom
gandholi-kumar:add_hamburger_menu_for_small_device

Conversation

@gandholi-kumar
Copy link
Copy Markdown
Contributor

Hi @devvsakib
Please review and approve my merge request.

Tasks Accomplished:

  1. Added the hamburger menu icon for medium and small devices(i.e. less than 'md': '768px')
  2. Address the unique key error displayed in the browser console in the Header.jsx file.

Screenshots:

Screen resolution Light Dark
Greated than Medium (>= 768px) image image image image
Less than Medium (<768px) image image image image

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github-error-solve ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 4:44pm

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, gandholi-kumar! 🎉 Thank you for submitting your first pull request to GES. Your contribution is valuable and we appreciate your efforts to improve our project. We'll review your changes and provide feedback as soon as possible. Keep up the great work!

@devvsakib
Copy link
Copy Markdown
Owner

I added hacktoberfest label bcz of your well-described description. Well done.

@gandholi-kumar
Copy link
Copy Markdown
Contributor Author

Thank you so much for reviewing and accepting the changes😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants