added copy button with toast#145
Merged
devvsakib merged 2 commits intodevvsakib:mainfrom Mar 12, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
there are some issues when you copy the solution. Less than sign is also included to clipboard |
devvsakib
requested changes
Mar 12, 2023
Owner
devvsakib
left a comment
devvsakib
left a comment
There was a problem hiding this comment.
Copied text contain < sign
git pull<git push origin [branch name]
Owner
|
Everything is perfect and love your work. But we have to remove < sign from clipboard |
Contributor
Author
|
just removing < will work, right? |
Contributor
Author
|
git pull git push origin [branch name] |
devvsakib
requested changes
Mar 12, 2023
src/components/Error/ErrorCard.jsx
Outdated
| <button | ||
| className="flex mt-8 items-center gap-2 mx-4 px-3 py-2 border border-gray rounded-lg hover:border-primary hover:text-primary" | ||
| onClick={() => { | ||
| navigator.clipboard.writeText(error.solutions); |
Owner
There was a problem hiding this comment.
Use this code in writeText function to remove < sign
error.solutions.split("<").join(" ")
devvsakib
approved these changes
Mar 12, 2023
Owner
devvsakib
left a comment
devvsakib
left a comment
There was a problem hiding this comment.
Perfect. Thanks for your contributions🟩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a copy button, which copies the commands on clicking this button and shows a toast after copying.
Here are some screenshots for the same: