fix: honor platform override on image pull and clarify wizard compat UX#501
Conversation
The desktop wizard's image-compatibility check ran but its result was invisible unless the image was incompatible, and the emulation override never worked: EnsureImage pulled without a platform flag, so an amd64-only image on an arm64 host failed at `docker pull` before `docker run --platform` was ever reached. - pkg/docker: refactor Pull to take a PullOptions config struct and thread Platform through to `docker pull --platform` - pkg/driver/docker: pass RunOptions.Platform into the pull - desktop wizard: review step now always resolves to a definite compat state (compatible / incompatible / unknown) instead of flashing "Checking…" and vanishing; list supported platforms - desktop wizard: drop confusing "Auto-suggested / Resolved id" lines; align Ref Type dropdown height with the adjacent input
✅ Deploy Preview for devsydev canceled.
|
|
Warning Review limit reached
More reviews will be available in 52 minutes and 40 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
mcr.microsoft.com/devcontainers/universal:2) on an arm64 host failed withno matching manifest for linux/arm64/v8.EnsureImagepulled the image with no platform flag, so the pull failed beforedocker run --platformwas ever reached — making the wizard's emulation override effectively dead.pkg/docker: refactorPullto take aPullOptionsconfig struct (Image,Platform,Stdin,Stdout,Stderr) and threadPlatformthrough todocker pull --platform.pkg/driver/docker:EnsureImagenow passesRunOptions.Platforminto the pull.Notes