chore(ci): tidy workflow comments#365
Merged
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughGitHub Actions workflows are updated across two files: desktop CI dependencies are reorganized to run npm and xvfb setup earlier while removing Python setup; section header comments are removed from desktop CI build/package/upload steps; and release promotion validation messaging is clarified. ChangesCI/CD Workflow Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced May 19, 2026
skevetter
added a commit
that referenced
this pull request
May 19, 2026
* fix(ci): pass app token via token input for softprops/action-gh-release (#361) softprops/action-gh-release@v3 reads the token from INPUT_TOKEN (set by the 'token' action input) before falling back to GITHUB_TOKEN. Setting env.GITHUB_TOKEN did not override INPUT_TOKEN so the action used the default GITHUB_TOKEN instead of the app-token, causing the 403. * feat(ci): enable autoMergeRequest in release-please action (#363) Adds autoMergeRequest: true to the googleapis/release-please-action step so that release-please PRs auto-merge after CI passes. * chore(main): release 1.3.0-rc.19 (#362) Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com> * feat: auto-overwrite stale agent binary and workspace clean command (#364) * feat: auto-overwrite agent binary on version mismatch in Docker delivery When the named Docker volume already contains an agent binary with a different version, force-overwrite it instead of leaving the stale binary in place. Logs an INFO message with the old and new versions. If versions match, skip re-delivery entirely as an optimization. * feat: add `devsy workspace clean` subcommand Adds a command to remove the agent binary from the Docker named volume for a workspace, forcing a fresh injection on next start. Useful when the binary becomes stale and the automatic version-mismatch detection is not sufficient. * fix: extract docker command string to constant (goconst lint) * chore(ci): tidy workflow comments (#365) * chore(main): release 1.3.0-rc.20 (#366) Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com> * feat(ci): replace single release-please config with dual prerelease/stable setup (#368) Split the release-please configuration into two independent tracks: - Prerelease track (push to main): creates RC releases with auto-merge - Stable track (workflow_dispatch): creates stable releases on demand This eliminates the promote-release.yml workaround that re-tagged RC commits as stable releases. Instead, release-please natively manages both version tracks with separate configs, manifests, labels, and changelog paths. * chore(main): release 1.3.0-rc.21 (#370) Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com> * fix(ci): advance prerelease manifest past stable release (#372) * fix: update workspace_result.json paths on workspace rename (#369) * fix: update workspace_result.json paths on workspace rename After renaming a workspace, the cached workspace_result.json still referenced the old workspace name in ContainerWorkspaceFolder, LocalWorkspaceFolder, and WorkspaceMount paths. This caused the container's working directory to point to /workspaces/<old-name> which doesn't exist, breaking exec and SSH into the workspace. * fix: also update MergedConfig.WorkspaceMount on workspace rename Closes a gap where MergedConfig.WorkspaceMount (a *string field) was not being rewritten during rename, leaving a stale mount path in the cached result. * refactor: derive workspace parent dirs dynamically in path replacer Instead of hardcoding `/workspaces` as the container workspace parent directory, derive it from SubstitutionContext.ContainerWorkspaceFolder by stripping the basename. Similarly derive the host parent from LocalWorkspaceFolder. This makes the rename path replacer work correctly for devcontainers that use a non-default workspaceFolder. * test: add unit tests for workspace rename path replacement * test: add e2e tests for workspace rename path updates Integration tests verifying that updateWorkspaceResult correctly rewrites ContainerWorkspaceFolder, LocalWorkspaceFolder, WorkspaceMount in SubstitutionContext and MergedConfig after a workspace rename. Covers: basic rename, non-default workspace dirs, nested paths, same-name idempotent rename, nil MergedConfig/WorkspaceMount, missing result file, and raw JSON roundtrip. * fix(lint): wire up testContainerOldWS, testLocalOldWS, testContainerApp, testContainerOld constants Linter introduced constants but left self-referential definitions and bare literals in test bodies. Fix init cycles and use constants throughout. * fix(lint): extract repeated /workspaces/ws-old literal to testContainerWSMount constant * chore(main): release 1.4.0-rc.1 (#373) Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com> * feat(ci): migrate from release-please to semantic-release (#374) Replace the dual release-please prerelease/stable configuration with a single semantic-release setup for simplicity. - Add .releaserc.json with commit-analyzer, release-notes-generator, changelog, github, and git plugins - Add semantic-release.yml workflow (push to main → RC, push to release → stable, plus dry-run workflow_dispatch) - Remove release-please workflows, configs, and manifests - Add semantic-release devDependencies to package.json * fix(ci): add package-lock.json for semantic-release workflow The semantic-release workflow uses actions/setup-node with npm caching, which requires a lock file to be present. Also switches from npm install to npm ci for reproducible CI builds. --------- Co-authored-by: Samuel K <skevetter@pm.me> Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com>
skevetter
added a commit
that referenced
this pull request
May 19, 2026
* fix(ci): pass app token via token input for softprops/action-gh-release (#361) softprops/action-gh-release@v3 reads the token from INPUT_TOKEN (set by the 'token' action input) before falling back to GITHUB_TOKEN. Setting env.GITHUB_TOKEN did not override INPUT_TOKEN so the action used the default GITHUB_TOKEN instead of the app-token, causing the 403. * feat(ci): enable autoMergeRequest in release-please action (#363) Adds autoMergeRequest: true to the googleapis/release-please-action step so that release-please PRs auto-merge after CI passes. * chore(main): release 1.3.0-rc.19 (#362) Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com> * feat: auto-overwrite stale agent binary and workspace clean command (#364) * feat: auto-overwrite agent binary on version mismatch in Docker delivery When the named Docker volume already contains an agent binary with a different version, force-overwrite it instead of leaving the stale binary in place. Logs an INFO message with the old and new versions. If versions match, skip re-delivery entirely as an optimization. * feat: add `devsy workspace clean` subcommand Adds a command to remove the agent binary from the Docker named volume for a workspace, forcing a fresh injection on next start. Useful when the binary becomes stale and the automatic version-mismatch detection is not sufficient. * fix: extract docker command string to constant (goconst lint) * chore(ci): tidy workflow comments (#365) * chore(main): release 1.3.0-rc.20 (#366) Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com> * feat(ci): replace single release-please config with dual prerelease/stable setup (#368) Split the release-please configuration into two independent tracks: - Prerelease track (push to main): creates RC releases with auto-merge - Stable track (workflow_dispatch): creates stable releases on demand This eliminates the promote-release.yml workaround that re-tagged RC commits as stable releases. Instead, release-please natively manages both version tracks with separate configs, manifests, labels, and changelog paths. * chore(main): release 1.3.0-rc.21 (#370) Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com> * fix(ci): advance prerelease manifest past stable release (#372) * fix: update workspace_result.json paths on workspace rename (#369) * fix: update workspace_result.json paths on workspace rename After renaming a workspace, the cached workspace_result.json still referenced the old workspace name in ContainerWorkspaceFolder, LocalWorkspaceFolder, and WorkspaceMount paths. This caused the container's working directory to point to /workspaces/<old-name> which doesn't exist, breaking exec and SSH into the workspace. * fix: also update MergedConfig.WorkspaceMount on workspace rename Closes a gap where MergedConfig.WorkspaceMount (a *string field) was not being rewritten during rename, leaving a stale mount path in the cached result. * refactor: derive workspace parent dirs dynamically in path replacer Instead of hardcoding `/workspaces` as the container workspace parent directory, derive it from SubstitutionContext.ContainerWorkspaceFolder by stripping the basename. Similarly derive the host parent from LocalWorkspaceFolder. This makes the rename path replacer work correctly for devcontainers that use a non-default workspaceFolder. * test: add unit tests for workspace rename path replacement * test: add e2e tests for workspace rename path updates Integration tests verifying that updateWorkspaceResult correctly rewrites ContainerWorkspaceFolder, LocalWorkspaceFolder, WorkspaceMount in SubstitutionContext and MergedConfig after a workspace rename. Covers: basic rename, non-default workspace dirs, nested paths, same-name idempotent rename, nil MergedConfig/WorkspaceMount, missing result file, and raw JSON roundtrip. * fix(lint): wire up testContainerOldWS, testLocalOldWS, testContainerApp, testContainerOld constants Linter introduced constants but left self-referential definitions and bare literals in test bodies. Fix init cycles and use constants throughout. * fix(lint): extract repeated /workspaces/ws-old literal to testContainerWSMount constant * chore(main): release 1.4.0-rc.1 (#373) Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com> * feat(ci): migrate from release-please to semantic-release (#374) Replace the dual release-please prerelease/stable configuration with a single semantic-release setup for simplicity. - Add .releaserc.json with commit-analyzer, release-notes-generator, changelog, github, and git plugins - Add semantic-release.yml workflow (push to main → RC, push to release → stable, plus dry-run workflow_dispatch) - Remove release-please workflows, configs, and manifests - Add semantic-release devDependencies to package.json * fix(ci): add package-lock.json for semantic-release workflow The semantic-release workflow uses actions/setup-node with npm caching, which requires a lock file to be present. Also switches from npm install to npm ci for reproducible CI builds. --------- Co-authored-by: devsy-app[bot] <277138668+devsy-app[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit