Skip to content

fix(ci): correct RC tag regex in promote-release workflow #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
May 18, 2026
Merged

fix(ci): correct RC tag regex in promote-release workflow #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/promote-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
inputs:
rc_tag:
description: "RC tag to promote (e.g., v1.1.0-rc1)"
description: "RC tag to promote (e.g., v1.3.0-rc.1)"
required: true
type: string

Expand All @@ -30,7 +30,7 @@ jobs:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
RC_TAG: ${{ inputs.rc_tag }}
run: |
if ! echo "$RC_TAG" | grep -qE '^v[0-9]+\.[0-9]+\.[0-9]+-rc[0-9]+$'; then
if ! echo "$RC_TAG" | grep -qE '^v[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$'; then
echo "::error::Invalid RC tag format: $RC_TAG (expected v*.*.*-rc*)"
Comment on lines +33 to 34

@coderabbitai coderabbitai Bot May 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Update the validation error message to match the new regex format.

Line 34 still says expected v*.*.*-rc*, but Line 33 now requires -rc.<number>. Please make the error explicit (for example: expected v<major>.<minor>.<patch>-rc.<number>).

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/promote-release.yml around lines 33 - 34, Update the
validation error message that references RC_TAG so it matches the stricter regex
used in the check (the grep on RC_TAG). Replace the vague text "expected
v*.*.*-rc*" with an explicit format such as "expected
v<major>.<minor>.<patch>-rc.<number>" so the error message clearly documents the
required tag format checked by the line using grep -qE
'^v[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$'.

exit 1
fi
Expand Down
Loading