Add best-practice analyzers for nuget packaging#334
Merged
Conversation
Warning for default description found, info for missing icon.
Issues an Info if a license isn't specified and an error if duplicate attributes are used.
Suggest installing SourceLink, setting PublishRepositoryUrl and having a sensible user-facing URL value for PackageProjectUrl.
Only while packing, since we don't want to annoy users with those for regular non-packing builds.
Makes it consistent with the diagnostics we emit, as well as build warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provided analyzers: