build(icomoon): fix missing eot file and add font metadata#2361
Conversation
|
As an alternative to this, we could programmatically modify the |
|
@ReenigneArcher |
|
@Snailedlt sounds good. I am good with this PR as is. It's the easiest and fastest approach to getting the build working again. I know it's not easy to review this one since the json is minified. The process I took was simply:
|
|
@ReenigneArcher wouldn't this need to be done for every release then, since |
|
No, it shouldn't need to be. I think the icomoon app just changed some of their settings so the way it was imported would no longer generate the |
|
What is needed to get this merged? Builds won't work until this is in. |
dcc06b8 to
668d08e
Compare
|
@ReenigneArcher All is good, just update this branch and it can be merged. |
668d08e to
e4ee895
Compare
|
@canaleal I rebased the branch. Thank you! |
Double check these details before you open a PR
Features
This PR fixes the issue of the missing
.eotfile when building the fonts.The issue was that the
Support IE 8checkbox was unselected in theicomoon.json. I also added some metadata to theicomoon.jsonThis PR closes NONE
Notes