Closed
Conversation
Snailedlt
requested changes
Mar 4, 2023
Collaborator
Snailedlt
left a comment
There was a problem hiding this comment.
I suggest we use newline-action instead of making our own newline script. And also I would prefer it if the script was moved to a different workflow all together.
See comment below for more info
Comment on lines
+38
to
+44
| - name: Setup Python v3.10 | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.10' | ||
|
|
||
| - name: Add newline | ||
| run: python ./.github/scripts/newliner.py ${{ env.SVGO }} |
Collaborator
There was a problem hiding this comment.
Any reason why we can't use the newline-action?
Suggested change
| - name: Setup Python v3.10 | |
| uses: actions/setup-python@v4 | |
| with: | |
| python-version: '3.10' | |
| - name: Add newline | |
| run: python ./.github/scripts/newliner.py ${{ env.SVGO }} | |
| - name: Add newline | |
| uses: Logerfo/newline-action@0.0.4 | |
| with: | |
| github-token: ${{ secrets.GITHUB_TOKEN }} |
This would add newline to any file, not just SVG files.
It's also possible to ignore files in a config (see link above)
Come to think of it, maybe it would be better to add the newline in a separate script like this:
name: Add newline
on:
pull_request:
types: [synchronize, opened]
jobs:
build:
name: newline-action
runs-on: ubuntu-16.04
steps:
- uses: actions/checkout@master
- uses: Logerfo/newline-action@0.0.4
with:
github-token: ${{ secrets.GITHUB_TOKEN }} # The `GITHUB_TOKEN` secret.
config-path: .github/newline.yml # The path of the addtional configurations file.
Member
|
Has not been updated in 2 years. Closing, but can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
Features
This feature adds
newliner.pyand changesoptimize_icons.ymltooptimizer.yml.About
optimizeroptimizerworkflow is triggered by any user commit to the pull request (synchronize) and byfeature:iconlabel.synchronize- This trigger adds a newline at the end of each file that is missing it.feature:icon- This trigger optimizes any icon with SVGO, it also adds a newline at the end of the optimized icon.This PR closes #1624 and changes #1554
Notes
We can change the label that triggers the icon optimization.
I've decided to make these two actions in one workflow, because some triggers are conflicting or not working properly, but if some way can be found to split them it would be nice to apply it.