add feature: vs code intellisense to devicon.json#1487
Merged
Snailedlt merged 6 commits intodevicons:developfrom Dec 10, 2022
Merged
add feature: vs code intellisense to devicon.json#1487Snailedlt merged 6 commits intodevicons:developfrom
devicon.json#1487Snailedlt merged 6 commits intodevicons:developfrom
Conversation
VS Code Intellisense provides these features:
- A snippet to create a new input object by typing `new`
- Validates
- `name` structure
- `color` structure
- `version.svg[]`, `version.font[]`, `aliases.?base` and `aliases.?alias` completion
- Provides some description for the properties based on the documentation
lunatic-fox
changed the title
devicon.jsondevicon.json
lunatic-fox
changed the title
devicon.jsondevicon.json
Snailedlt
requested changes
Oct 31, 2022
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Looking great!
One of the features I'm most looking forwards too, since this will boost productivity so much!
As always, there's a few suggestions I'd like you to look at before we're ready for merging this. Great general structure though, definitely good work! 💯
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Great! Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Agreed! It's more detailed now! Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Great! Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
This was referenced Nov 2, 2022
1 task
Snailedlt
approved these changes
Nov 7, 2022
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Looking good! ✔️
Can't wait to get this into master, well done with the changes :)
Contributor
Author
|
@Panquesito7, please review this request. 🙂 |
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* Add VS Code Intellisense to `devicon.json`
VS Code Intellisense provides these features:
- A snippet to create a new input object by typing `new`
- Validates
- `name` structure
- `color` structure
- `version.svg[]`, `version.font[]`, `aliases.?base` and `aliases.?alias` completion
- Provides some description for the properties based on the documentation
* Fix name pattern and add `dot-net` exception
* Update .vscode/devicon-schema.json
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* Update .vscode/devicon.code-snippets
Great!
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* Update .vscode/devicon-schema.json
Agreed! It's more detailed now!
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* Update .vscode/devicon-schema.json
Great!
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
Features
VS Code Intellisense to
devicon.jsonprovides these features:newnamestructurecolorstructureversion.svg[],version.font[],aliases.?baseandaliases.?aliascompletionThis PR closes #1481
Notes