Bugfix/fix in devicon.json#1485
Conversation
Co-authored-by: David Leal <halfpacho@gmail.com>
- Remove unnecessary aliases of `sequelize` in `devicon.json`
Snailedlt
left a comment
There was a problem hiding this comment.
That's a lot of commits for a small change, consider redoing the branch or rebasing on develop next time, so it's easier for reviewers to look through it :)
That said, nice catch 🕵️
Thanks for making a PR on it, very much appreciated 🙏
|
@lunatic-fox |
I'll be doing that next time. |
|
@lunatic-fox hehe, yeah... In this case there was no issue, and it's rarely an issue for devicons since we do squash merging which squashes all of the commits into a single commit on the develop branch. However it could become an issue if there's a big feature, where you make multiple changes :) So just sort of a side note |
|
Btw, we should probably add this alias/base duplicate value check to our |
That's great! |
* Add Ren'Py * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Fix versions and aliases of `handlebars` and `yarn` * Bugfix/fix in devicon.json - Remove unnecessary aliases of `sequelize` in `devicon.json` Co-authored-by: David Leal <halfpacho@gmail.com>
Double check these details before you open a PR
Features
Removes unnecessary aliases of
sequelizeindevicon.jsonThis PR closes NONE
Notes