refactor: flatten nested if-else blocks#6
Open
cades wants to merge 5 commits intodevelopit:masterfrom
Open
Conversation
Owner
|
Need to check the effect on filesize, but I'd imagine this is a savings! (due to uglify better optimizing early returns than nested conditionals) |
developit
reviewed
Jan 11, 2018
src/index.js
Outdated
| return; | ||
| } | ||
|
|
||
| Promise.resolve(() => method.apply(null, data.params)) |
Owner
There was a problem hiding this comment.
This creates a Promise with a value resolved to the function itself. See below:
Owner
|
hey @cades - that nested |
Author
|
@developit thanks for point that out! Seems my knowledge to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply "return early, avoid else" practice to make code simple and easy to read