Fix/css filename output#841
Merged
ForsakenHarmony merged 2 commits intodevelopit:masterfrom May 26, 2021
rschristian:fix/css-filename-output
Merged
Fix/css filename output#841ForsakenHarmony merged 2 commits intodevelopit:masterfrom rschristian:fix/css-filename-output
ForsakenHarmony merged 2 commits intodevelopit:masterfrom
rschristian:fix/css-filename-output
Conversation
🦋 Changeset detectedLatest commit: 6602872 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ForsakenHarmony
approved these changes
May 26, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #779
I'd love to do / add some better detection here, but not sure how reasonable it is considering the current state of things. Ideally (in my mind at least) names would be chosen in a way resembling the following order:
".css"key in"exports""exports": { "./": { default } }"exports": { "./" }, if it's a string"exports", if it's a string"main"options.outputI believe that'd make sense as a set of fallbacks, but the point is that those would be some reasonable items to use as the CSS file name.
However, besides #784 we're not currently using
"exports"for any detection / output customization so it would feel weird to have CSS be the first thing to utilize that. Certainly happy to add that if it'd make sense to do so!