Add RHEL support to node feature.#823
Merged
samruddhikhandale merged 7 commits intodevcontainers:mainfrom Jan 31, 2024
Merged
Conversation
samruddhikhandale
requested changes
Jan 31, 2024
Member
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
Another powerful PR 🎉
Thank you, left some minor comments
samruddhikhandale
approved these changes
Jan 31, 2024
Member
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
Looks great, let's wait for the tests, then we are good to merge! ⚡
Contributor
Author
|
Samruddhi: Thank you for helpful comments and good feedback. Glad to be able to help with the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds RHEL support to node feature.
CentOS 7, RHEL/Alma/Rocky Linux 8 & 9, Mariner, and Fedor should all work. Tests for all of these are included.
resolves #822