feat(accessibility): support PageTab role and selected state on buttons#304
Open
rezabakhshilaktasaraei wants to merge 1 commit into
Open
Conversation
ilya-fedin
reviewed
Jun 17, 2026
| state.selected = selected ? 1 : 0; | ||
| // Only ever set focused, never clear it, so the real keyboard-focus | ||
| // state from QAccessibleWidget is preserved. Used to expose the active | ||
| // tab as focused, the way QTabBar marks its current tab. |
Contributor
There was a problem hiding this comment.
QAccessibleTabBar seem to manipulate with focused state only because the child items aren't real widgets. Since you're changing RpWidget, I assume they're real widgets in our case and you can use setFocus instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the building blocks to expose buttons as accessible page tabs (used by Telegram Desktop to turn the chat-folders strip into a screen-reader tab control):
AbstractButton:setIsPageTab()/isPageTab(), andaccessibilityRole()returnsPageTabwhen set (alongside the existingButtonMenu/Button).AccessibilityState: newfocusedfield, written OR-only inwriteTo()so the real keyboard-focus state fromQAccessibleWidgetis never cleared — used to mark the active tab as focused, the wayQAccessibleTabButtonmarksQTabBar's current tab.SideBarButton:accessibilityState()reportsfocused = _activefor a page tab, so the active side-bar item is exposed as the selected/focused tab.On Windows, the screen reader's "selected" announcement for a
PageTabadditionally relies on a small qtbase UIA patch (exposing the SelectionItem pattern forPageTab, which Qt 6 already does); the role/focus work regardless.