feat(accessibility): support SetFocus and Press actions on painted list items#303
Open
rezabakhshilaktasaraei wants to merge 2 commits into
Open
Conversation
rezabakhshilaktasaraei
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Painted/virtual list items exposed via
Accessible::Itemadvertise themselves as focusable, but they provided noQAccessibleActionInterface. As a result a screen reader could neither move focus to such an item (UIASetFocusreturnedUIA_E_ELEMENTNOTAVAILABLE) nor activate it (UIAInvokehad nothing to call).This makes
Accessible::ItemimplementQAccessibleActionInterfaceand forward the two relevant actions to the owning widget:interface_castnow returns the action interface.actionNames()advertisespressAction()(the item's default activate action) and, when the parent reports the row as focusable,setFocusAction().doAction()routes:setFocusAction()-> newRpWidget::accessibilityChildSetFocus(int index)pressAction()-> newRpWidget::accessibilityChildActivate(int index)Both new
RpWidgetvirtuals default to no-ops, so the owning widget can opt in and translate the requests into its own selection / activation model (e.g. the chat list moving its selection, or opening the chat).