Skip to content

BREAKING(http/unstable): split parseProblemDetails, validate status, add statusText option#7117

Open
tomas-zijdemans wants to merge 4 commits intodenoland:mainfrom
tomas-zijdemans:problem-ready
Open

BREAKING(http/unstable): split parseProblemDetails, validate status, add statusText option#7117
tomas-zijdemans wants to merge 4 commits intodenoland:mainfrom
tomas-zijdemans:problem-ready

Conversation

@tomas-zijdemans
Copy link
Copy Markdown
Contributor

@tomas-zijdemans tomas-zijdemans commented Apr 27, 2026

  • Split parseProblemDetails into sync (unknown input) and async parseProblemDetailsResponse.
  • Add statusText option to ProblemDetailsResponseOptions, forwarded to Response only when defined.
  • Throw RangeError for non-integer status in createProblemDetailsResponse.
  • Rewrite ProblemDetailsExtensions JSDoc to honestly describe the intersection-based safety.
  • Tighten isProblemDetailsResponse docs; add @throws tags throughout.
  • Add runnable Response parse example; replace Record<never, never> defaults with Record<string, never>.
  • Backfill tests for status validation, statusText forwarding, and primitive bodies.

@github-actions github-actions Bot added the http label Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.61%. Comparing base (a496da2) to head (3e22841).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7117   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files         634      634           
  Lines       51801    51815   +14     
  Branches     9329     9336    +7     
=======================================
+ Hits        49011    49025   +14     
  Misses       2216     2216           
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant