feat(cache/unstable): add peek() to TtlCache#7070
Merged
bartlomieju merged 1 commit intodenoland:mainfrom Mar 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7070 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 630 630
Lines 50486 50490 +4
Branches 8946 8949 +3
=======================================
+ Hits 47666 47670 +4
Misses 2249 2249
Partials 571 571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomas-zijdemans
added a commit
to tomas-zijdemans/std_cb
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
peekto TtlCache, as the only way to read without side effects bringing symmetry withLruCache.Both caches have a "read touches state" method (
get). For LRU,getpromotes. For TTL with sliding expiration,getresets the timer.... and now both have a "read without touching state" method (
peek).Note: Also fixes the bug introduced here, where the input validation was happening too late.