refactor(http): remove unstable header and method modules#7004
Open
tomas-zijdemans wants to merge 5 commits intodenoland:mainfrom
Open
refactor(http): remove unstable header and method modules#7004tomas-zijdemans wants to merge 5 commits intodenoland:mainfrom
tomas-zijdemans wants to merge 5 commits intodenoland:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7004 +/- ##
==========================================
- Coverage 94.61% 94.59% -0.03%
==========================================
Files 634 632 -2
Lines 51801 51588 -213
Branches 9329 9329
==========================================
- Hits 49011 48798 -213
Misses 2216 2216
Partials 574 574 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Feb 14, 2026
Contributor
|
note: these were originally added in #4317 and #4320 what do people think? cc @halvardssm |
Contributor
|
What is the reasoning for removing them? I personally find it quite useful to have such headers and other static properties defined in the standard library as it reduces the amount of accidental typos. Not against keeping them in sync with the IANA registry. |
Contributor
Author
Please see the discussion here: https://discord.com/channels/684898665143206084/775393009981849600/1472185311118495796 |
Contributor
Author
|
Rebased on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we want to keep it, then these should be considered for merging instead: #6991 and #6992