Skip to content

Add support for boolean arguments in optimizer, loss fn. Fixes #1933 #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brollb merged 1 commit into from
Oct 7, 2020
+27 −17
Merged

Add support for boolean arguments in optimizer, loss fn. Fixes #1933 #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 23 additions & 13 deletions src/visualizers/widgets/TrainKeras/TrainDashboard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
let eventElement;

function decorateSchemas(schemas) {
let index = 1;
schemas.losses.concat(schemas.optimizers).forEach(fn => {
fn.arguments = fn.arguments
.filter(arg => arg.name !== 'name')
Expand All @@ -31,10 +32,13 @@
arg.type = typeof(arg.default);
}
arg.value = arg.default;
if (arg.type === 'boolean') {
console.warn('Unsupported argument:', arg);
}
arg.id = `arg${index++}`;
return arg;
})
.sort((arg1, arg2) => {
const [num1, num2] = [arg1, arg2]
.map(arg => arg.type === 'boolean' ? 1 : 0)
return num1 - num2;
});
});
}
Expand Down Expand Up @@ -252,18 +256,21 @@
{#each loss.arguments as arg}
<div class="form-group">
{#if arg.type === 'string'}
<label for="{arg.name}">{arg.name}</label>
<input id="{arg.name}" bind:value={arg.value} type="text"/>
<label for="{arg.id}">{arg.name}</label>
<input id="{arg.id}" bind:value={arg.value} type="text"/>
{:else if arg.type === 'boolean'}
<input id="{arg.id}" bind:checked={arg.value} type="checkbox"/>
<label for="{arg.id}">{arg.name}</label>
{:else if arg.type === 'enum'}
<label for="{arg.name}">{arg.name}</label>
<select id="{arg.name}" bind:value={arg.value}>
<label for="{arg.id}">{arg.name}</label>
<select id="{arg.id}" bind:value={arg.value}>
{#each arg.options as option}
<option value={option}>{option}</option>
{/each}
</select>
{:else}
<label for="{arg.name}">{arg.name}</label>
<input id="{arg.name}" bind:value={arg.value} type="number"/>
<label for="{arg.id}">{arg.name}</label>
<input id="{arg.id}" bind:value={arg.value} type="number"/>
{/if}
</div>
{/each}
Expand All @@ -281,11 +288,14 @@
{#each optimizer.arguments as arg}
<div class="form-group">
{#if arg.type === 'string'}
<label for="{arg.name}">{arg.name}</label>
<input id="{arg.name}" bind:value={arg.value} type="text"/>
<label for="{arg.id}">{arg.name}</label>
<input id="{arg.id}" bind:value={arg.value} type="text"/>
{:else if arg.type === 'boolean'}
<input id="{arg.id}" bind:checked={arg.value} type="checkbox"/>
<label for="{arg.id}">{arg.name}</label>
{:else}
<label for="{arg.name}">{arg.name}</label>
<input id="{arg.name}" bind:value={arg.value} type="number"/>
<label for="{arg.id}">{arg.name}</label>
<input id="{arg.id}" bind:value={arg.value} type="number"/>
{/if}
</div>
{/each}
Expand Down
Loading