Replace ace with monaco editor (Closes #571)#1800
Conversation
| this.logger = logger.fork('Widget'); | ||
| MonacoLanguages = JSON.parse(MonacoLanguages); | ||
| const DEFAULT_THEMES = ['vs-dark', 'vs', 'hc-black']; | ||
| const DEFAULT_COLORS = { |
There was a problem hiding this comment.
It looks like this can be removed.
There was a problem hiding this comment.
Due to the lack of submenu support and already exsiting context menu. My plan was to add a separate button. This which opens the existing contextmenu. These colors were used in #1746 for the button in the context menu.
| TextEditorWidget = function (logger, container, config={}) { | ||
| this.logger = logger.fork('Widget'); | ||
| MonacoLanguages = JSON.parse(MonacoLanguages); | ||
| const DEFAULT_THEMES = ['vs-dark', 'vs', 'hc-black']; |
There was a problem hiding this comment.
It might be nice to have a couple more themes available. Maybe 5 or 6?
There was a problem hiding this comment.
https://github.com/brijeshb42/monaco-themes. Similar to #1800 (comment). Which would be the best course?
|
It is to be noted that the current Python terminal(Bash Shell) Output in deepforge:
|
|
Can you share the raw text before it is rendered? |
|
The raw text is the following: |
|
Ah, I see. The first one is using underlines and other SGR parameters; it currently only supports colors and expected there to be only two options. This should be pretty easy fix but could be fixed in it's own PR. |
…-monaco-text-editor
|
I am marking this active. There is one issue left to sortout: Somehow, 2 editor workers are being assingned when viewing stdout in Also, following issues will stem and should be addressed after this is merged:
|
|
I am still seeing the following warning :/ |
brollb
left a comment
brollb
left a comment
There was a problem hiding this comment.
Looks good! If you can remove the console.log, it should be good to go!
|
This PR only is part one of the two needed to close #571. This Introduces Monaco Text Editor, which has support for a language server protocol. |
umesh-timalsina
changed the title
2 participants
Checklist:
Apply Basic Changes to panels
LogViewerOperationCodeEditorOperationDepEditorTabbedTextEditorSerializeEditorAdd Support for different themes, via contextmenu
Add support for keybindings (Currently, Only VIM is supported, Emacs can be added on a later PR/issue)