Allow type change in ArtifactIndex (Closes #1681)#1682
Conversation
|
For clarity, this enables users to modify the type information in an artifact's metadata. It does not change the associated data in any way. |
brollb
left a comment
brollb
left a comment
There was a problem hiding this comment.
The commit message comment is more pressing. The other issue is minor and a comment on legibility/maintainability but it isn't blocking the merge.
|
For more clarity on the ramifications of changing the |
…change 1. Change meaninfule commit message when changing the attribute of an Artifact Node. 2. Add a ConfirmDialog with warnings for artifact data type Change and change it only if confirmed.
brollb
left a comment
brollb
left a comment
There was a problem hiding this comment.
One minor comment. Otherwise, it looks good!
| if (newVal && newVal !== oldVal) { | ||
| const confirmed = opts.confirmation ? await opts.confirmation.call(this, | ||
| opts.nodeName, | ||
| {newValue: newVal, oldValue: oldVal} |
There was a problem hiding this comment.
As a minor point, I am not a fan of packing arguments into an options object unless there are a lot of optional arguments. Otherwise, it obscures the method signature without any real benefit.
umesh-timalsina
force-pushed
the
1681-artifacts-type-change
branch
from
7e280a9 to
f425b7d
Compare
2 participants
No description provided.